Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case filter to RunOptions (Support for #327) #352

Closed

Conversation

MattRyan
Copy link

@MattRyan MattRyan commented Aug 8, 2018

Add constructor overloads to RunOptions to take a ContextFilter instead of a string. ContextFilters class consists of a name property and a set of SpecificationFilters. A SpecificationFilter contain just a name property. ContextFilters without any SpecificationFilters will behave the same as the current string filters. When any SpecificationFilters exist only the specifications with a matching name in that context will be run.

@MattRyan MattRyan mentioned this pull request Aug 8, 2018
- Iterating the contexts inside the filter was causing context to be
created early.
@robertcoltheart
Copy link
Member

The change of type for Filters isn't going to play nicely with the Runner.Utility which relies on this being a string. I need to think about this more carefully.

@mikeblakeuk
Copy link
Contributor

@robertcoltheart is there any news on support for vstest.console.exe Filters supporting the Tag attribute?

@robertcoltheart
Copy link
Member

Now that we've hit version 1.0, we're looking at refactoring and cleaning up a lot of the codebase. Tag support in the console runner will likely be a 2.0 feature.

@robertcoltheart
Copy link
Member

Closing this while we refactor, tracked in #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants