You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
takes around 20 seconds on my machines. If possible, should be shorter. (I guess we can live with it otherwise). not sure who I should assign.
The text was updated successfully, but these errors were encountered:
luator
changed the title
threadsafe_timeseries.partial_history ut takes too long
threadsafe_timeseries.partial_history unit test takes too long
Dec 11, 2019
I looked at the code of the test. In the partial_history case, the slow flag is set to true which results in adding a 1ms sleep in a loop here.
There are two options to speed up the test:
reduce the sleep duration (might not be desired for this test?)
reduce the length of the input data (=number of iterations of the loop containing the sleep). Currently the length is hard-coded here.
I am not familiar with this test. Would reducing the length be okay or would this invalidate the test in some way? @mwuethri maybe you can take a look, this seems to be at least partially coming from you.
yes, reducing the data length should be fine (as long as it is longer than the time-series).
i am not familiar with this test anymore because @MaximilienNaveau rewrote it almost completely. i think he also added the extended sleep, which makes it so slow, to prevent issues on non-realtime machines. @MaximilienNaveau could you have a look at the issue above?
@luator
takes around 20 seconds on my machines. If possible, should be shorter. (I guess we can live with it otherwise). not sure who I should assign.
The text was updated successfully, but these errors were encountered: