Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run validator as part of regular Bookmaker #106

Open
nelliemckesson opened this issue May 4, 2017 · 4 comments
Open

Run validator as part of regular Bookmaker #106

nelliemckesson opened this issue May 4, 2017 · 4 comments

Comments

@nelliemckesson
Copy link
Contributor

nelliemckesson commented May 4, 2017

When validator runs, also run the VBA style report and return the output to the PM, along with a note along the lines of: "Bookmaker tried to fix some of these items as best it could, but you should check it out."

@MacmillanWorkflows MacmillanWorkflows changed the title Run style report as part of validator Run validator as part of regular Bookmaker Sep 6, 2017
@MacmillanWorkflows
Copy link
Member

➤ erica.warren commented:

Now that we're moving the Style Report to Python, this would be running the Python validator as part of Bookmaker, and return errors to users.

@MacmillanWorkflows
Copy link
Member

➤ Matthew Retzer commented:

We could run reporter instead. Something useful needs to be returned to users though, as we change the way ncx's are handled and section start paras require contents

@MacmillanWorkflows
Copy link
Member

➤ erica.warren commented:

Perhaps: (1) Add error if section-start is blank; (2) Always run validator prior to running Bookmaker; (3) If validator returns errors, email user and DON'T run Bookmaker; (4) If validator passes, run Bookmaker, then send user an email alert that Bookmaker has finished, and also give them the validator output so they can see what we identified as sections, illustration file names, etc. as a first place to check if they don't get the output they want.

We'll probably need a not-widely-publicized (or not-user configurable) way to override (3) in case we get manuscripts with unexpected elements that trigger errors but don't actually have errors.

@MacmillanWorkflows
Copy link
Member

➤ erica.warren commented:

And yes, by "validator" I meant "reporter" here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants