-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run validator as part of regular Bookmaker #106
Comments
➤ erica.warren commented: Now that we're moving the Style Report to Python, this would be running the Python validator as part of Bookmaker, and return errors to users. |
➤ Matthew Retzer commented: We could run reporter instead. Something useful needs to be returned to users though, as we change the way ncx's are handled and section start paras require contents |
➤ erica.warren commented: Perhaps: (1) Add error if section-start is blank; (2) Always run validator prior to running Bookmaker; (3) If validator returns errors, email user and DON'T run Bookmaker; (4) If validator passes, run Bookmaker, then send user an email alert that Bookmaker has finished, and also give them the validator output so they can see what we identified as sections, illustration file names, etc. as a first place to check if they don't get the output they want. We'll probably need a not-widely-publicized (or not-user configurable) way to override (3) in case we get manuscripts with unexpected elements that trigger errors but don't actually have errors. |
➤ erica.warren commented: And yes, by "validator" I meant "reporter" here. |
When validator runs, also run the VBA style report and return the output to the PM, along with a note along the lines of: "Bookmaker tried to fix some of these items as best it could, but you should check it out."
The text was updated successfully, but these errors were encountered: