Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: can we refactor with_test_settings in ethereum settlement client #130

Open
apoorvsadana opened this issue Sep 25, 2024 · 0 comments
Open

refactor: can we refactor with_test_settings in ethereum settlement client #130

apoorvsadana opened this issue Sep 25, 2024 · 0 comments

Comments

@apoorvsadana
Copy link
Contributor

We maybe don't need with_test_settings here https://github.com/karnotxyz/madara-orchestrator/blob/89399ca09497d5deda1b229321a9e89faaec492c/crates/settlement-clients/ethereum/src/lib.rs#L71 as the code is the exact same as with_settings. Only the arguments are passed in the function so we can maybe just set it in the env in the test case itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apoorvsadana