Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clean): dc_db: rename DbBlockId::BlockN to DbBlockId::Number #217

Open
cchudant opened this issue Aug 5, 2024 · 1 comment · May be fixed by #310
Open

feat(clean): dc_db: rename DbBlockId::BlockN to DbBlockId::Number #217

cchudant opened this issue Aug 5, 2024 · 1 comment · May be fixed by #310
Assignees
@shamsasari
Labels
code quality

Comments

@cchudant
Copy link
Member

cchudant commented Aug 5, 2024

Lifted from @tdelabro's review comment in #198

DbBlockId::BlockN should be renamed DbBlockId::Number in dc_db so that it reads better
@cchudant cchudant mentioned this issue Aug 6, 2024
Closed
1 task
@varun-doshi
Copy link

I'd like to take this up

@antiyro antiyro changed the title dc_db: rename DbBlockId::BlockN to DbBlockId::Number feat(clean): dc_db: rename DbBlockId::BlockN to DbBlockId::Number Sep 25, 2024
@shamsasari shamsasari self-assigned this Oct 4, 2024
@shamsasari shamsasari linked a pull request Oct 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shamsasari shamsasari

Labels
code quality
Projects
Madara
Status: In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(clean): dc_db: rename DbBlockId::BlockN to DbBlockId::Number madara-alliance/madara
3 participants
@shamsasari @cchudant @varun-doshi