Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename min-font-size to font-min-size like in CSS Fonts Module Level 4 #32

Open
wimhendrikx opened this issue Dec 17, 2018 · 1 comment

Comments

@wimhendrikx
Copy link

https://www.w3.org/TR/css-fonts-4/#font-min-max-size-prop

@madeleineostoja
Copy link
Owner

madeleineostoja commented Dec 18, 2018

Ooh nice. Was going to say wouldn't want to cause a conflict between custom props we use vs. potential future specs, but sounds like they do exactly the same thing.

Happy to accept a PR for this — it'd have to be a breaking change though. Might also be worth adding a preserveProperties or similar option, to not remove font-min-size and font-max-size rules from user CSS after processing, in in case native support ever lands. Would also have to rename the respective line-height and letter-spacing props, and update docs and tests. And probably rename the *-range props to be consistent as well (eg: font-lower-range)

@madeleineostoja madeleineostoja changed the title Maybe rename min-font-size to font-min-size like in CSS Fonts Module Level 4? Rename min-font-size to font-min-size like in CSS Fonts Module Level 4 Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants