Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Lists Support #54

Open
wate opened this issue Jun 27, 2014 · 12 comments
Open

Task Lists Support #54

wate opened this issue Jun 27, 2014 · 12 comments

Comments

@wate
Copy link

wate commented Jun 27, 2014

Writing on GitHub
https://help.github.com/articles/writing-on-github#task-lists

@junichi11
Copy link
Collaborator

What's the feature that you expect ?
(e.g. highlighting

Thanks.

@wate
Copy link
Author

wate commented Jun 27, 2014

「Task lists」の機能に対応してもらえるとありがたいです

@junichi11
Copy link
Collaborator

すみません、まだ期待されていることがわかっていません。。。 具体的にはどういうことでしょうか? Previewでの表示でしょうか? 改行時のリストの自動追加(- [ ])でしょうか?

@wate
Copy link
Author

wate commented Jun 27, 2014

GFMには[ ][x]でチェックボックスおよび、
チェックボックスのチェックされてるかどうかの状態を表現できるんですが、
その機能のことを指してます。
最初のリンクに項目に「Task lists」って表記だったんで、それにあわせたんですけど、
余計にわかりにくかったですかね・・

もしかしたら、こっちのほうがわかりやすいかもかも知れないんで
別のリンクページをのURLを記載しておきます。

Task Lists in GFM: Issues/Pulls, Comments
https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments

さすがに相互に反映ってのは無理があると思うんですが、
HTML出力時にチェックボックスに変換してくれるだけでも、
人に見せやすくなるんで助かるかなーって感じで思ってます。

@junichi11
Copy link
Collaborator

何度もお手数をおかけしましたm(_ _)m 理解いたしました。Task lists の機能は知っていたのですが、その機能のことではなく、プラグイン側が対応する具体的な内容(エディタでの入力時やハイライトのサポートだったり、HTMLへの変換後の表示だったり)を知りたかったのです。

変換部分は他の人が実装していますので、このまま聞いてみますね。

@junichi11
Copy link
Collaborator

@madflow @stengerh
If we use task lists in GFM (- [ ], - [x]), convert them to checkboxes when generate Html from markdown text.
What do you think about this feature? Could you implement it?

@madflow
Copy link
Owner

madflow commented Jun 27, 2014

@junichi11 We use pegdown for these tasks. Pegdown does not support this Github dialect feature (yet). But since it supports plugins (https://github.com/sirthias/pegdown#plugins) I reckon this feauture could be implemented without hacking directly on the core library.

It should be toggled under Options like all the other extensions in the NetBeans Markdown Plugin.

Since Github is a big driver for writing documentation in markdown I do not mind implementing their feautures. I hope they do not come up with a <blink> Tag markdown feature though :D (jkjk).

@junichi11
Copy link
Collaborator

@madflow Thanks for your reply :)

It should be toggled under Options like all the other extensions in the NetBeans Markdown Plugin.

I think so 👍

@madflow
Copy link
Owner

madflow commented Jul 16, 2014

I have problem finding the specs for this feature. There is a Blog post:

https://github.com/blog/1825-task-lists-in-all-markdown-documents

@wate do you know if there there is an open source version of actual implementation + tests ?

@wate
Copy link
Author

wate commented Oct 16, 2014

@Chris2011
Copy link

Chris2011 commented Jun 8, 2017

As I see it here: https://github.com/sirthias/pegdown:

>>> DEPRECATION NOTE <<<:

Although still one of the most popular Markdown parsing libraries for the JVM, pegdown has reached its end of life.

The project is essentially unmaintained with tickets piling up and crucial bugs not being fixed.
pegdown's parsing performance isn't great. In some cases of pathological input runtime can even become exponential, which means that the parser either appears to "hang" completely or abort processing after a time-out.

time to change the parser to e.g.: https://github.com/vsch/flexmark-java or https://github.com/atlassian/commonmark-java

Faster and more active.

@Chris2011
Copy link

Benchmarks can be find on the flexmark page. Would be great to have a better, faster implementation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants