-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task Lists Support #54
Comments
What's the feature that you expect ? Thanks. |
「Task lists」の機能に対応してもらえるとありがたいです |
すみません、まだ期待されていることがわかっていません。。。 具体的にはどういうことでしょうか? Previewでの表示でしょうか? 改行時のリストの自動追加( |
GFMには もしかしたら、こっちのほうがわかりやすいかもかも知れないんで Task Lists in GFM: Issues/Pulls, Comments さすがに相互に反映ってのは無理があると思うんですが、 |
何度もお手数をおかけしましたm(_ _)m 理解いたしました。Task lists の機能は知っていたのですが、その機能のことではなく、プラグイン側が対応する具体的な内容(エディタでの入力時やハイライトのサポートだったり、HTMLへの変換後の表示だったり)を知りたかったのです。 変換部分は他の人が実装していますので、このまま聞いてみますね。 |
@junichi11 We use pegdown for these tasks. Pegdown does not support this Github dialect feature (yet). But since it supports plugins (https://github.com/sirthias/pegdown#plugins) I reckon this feauture could be implemented without hacking directly on the core library. It should be toggled under Since Github is a big driver for writing documentation in markdown I do not mind implementing their feautures. I hope they do not come up with a |
@madflow Thanks for your reply :)
I think so 👍 |
I have problem finding the specs for this feature. There is a Blog post: https://github.com/blog/1825-task-lists-in-all-markdown-documents @wate do you know if there there is an open source version of actual implementation + tests ? |
As I see it here: https://github.com/sirthias/pegdown: >>> DEPRECATION NOTE <<<:
Although still one of the most popular Markdown parsing libraries for the JVM, pegdown has reached its end of life.
The project is essentially unmaintained with tickets piling up and crucial bugs not being fixed.
pegdown's parsing performance isn't great. In some cases of pathological input runtime can even become exponential, which means that the parser either appears to "hang" completely or abort processing after a time-out. time to change the parser to e.g.: https://github.com/vsch/flexmark-java or https://github.com/atlassian/commonmark-java Faster and more active. |
Benchmarks can be find on the flexmark page. Would be great to have a better, faster implementation here. |
Writing on GitHub
https://help.github.com/articles/writing-on-github#task-lists
The text was updated successfully, but these errors were encountered: