Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout du test pour getSchoolInfos (+update des types pour faire le test) #45

Merged
merged 15 commits into from
May 3, 2024

Conversation

Vilerio
Copy link
Contributor

@Vilerio Vilerio commented May 3, 2024

Description de la demande de fusion

J'ai ajouté le test pour getSchoolInfos, j'ai donc du modifier des types. SVP VERIFIEZ BIEN MES MODIFS SUR LES TYPES, j'ai l'impression que ça peut bcp varier en fonction des différentes actualités

Type de changement

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality) (toujours pas sûr que ce soit une feature mais bon)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Mon code ne met pas en danger les données personnelles des utilisateurs
  • Les noms des commits suivent la convention Conventional Commits
  • J'ai vérifié l'entièreté du code avant de le soumettre
  • J'ai mis à jour la documentation en lien avec mes commits
  • Mon code ne génère pas d'erreurs
  • J'ai ajouté les tests unitaires correspondants (dossier tests)
  • Les anciens et nouveaux tests unitaires sont validés en local

Note

Avant de fusionner cette PR, elle devra recevoir l'approbation d'au moins une des personnes suivantes :

src/models/School/Attachment.ts Outdated Show resolved Hide resolved
src/models/School/School.ts Outdated Show resolved Hide resolved
src/models/School/SchoolInfo.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
test/user.test.ts Outdated Show resolved Hide resolved
test/user.test.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
test/user.test.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@maelgangloff maelgangloff merged commit 1b9cdd2 into maelgangloff:master May 3, 2024
2 checks passed
@maelgangloff
Copy link
Owner

Merci @Vilerio pour ta contribution ! 🎉

@Vilerio
Copy link
Contributor Author

Vilerio commented May 3, 2024

tjr pas grand chose, dr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants