Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ob_end_clean throws error if output buffer is not active #19

Open
Schrank opened this issue Nov 17, 2020 · 0 comments · May be fixed by #22
Open

ob_end_clean throws error if output buffer is not active #19

Schrank opened this issue Nov 17, 2020 · 0 comments · May be fixed by #22
Assignees
Labels
bug Something isn't working

Comments

@Schrank
Copy link
Contributor

Schrank commented Nov 17, 2020

To test QPS and when calling the test rule (/mageone/test/rule/?Malicious=<script>) a notification is displayed in "community/Mageone/Qps/Model/Observer.php: 161"

ob_end_flush () : ob_end_flush(): failed to delete and flush buffer. No buffer to delete or flush

and then goes to catch and the page is redirected to 404.

I wrote below code on this line instead of ob_end_clean().

if (ob_get_contents ()) {
    ob_end_clean ();
}
@Schrank Schrank added the bug Something isn't working label Nov 17, 2020
@Schrank Schrank self-assigned this Nov 17, 2020
Schrank added a commit that referenced this issue Feb 19, 2021
Fixes #19 ob_end_clean throws error if output buffer is not active
@Schrank Schrank linked a pull request Feb 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant