Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConditionalTargetAdjuster more permissive in canChooseTargetAbility than ideal #12819

Open
ssk97 opened this issue Sep 7, 2024 · 0 comments
Open

ConditionalTargetAdjuster more permissive in canChooseTargetAbility than ideal #12819

ssk97 opened this issue Sep 7, 2024 · 0 comments
Assignees
@JayDi85
Labels
refactoring Developers topics about code and programming

Comments

@ssk97
Copy link
Contributor

ssk97 commented Sep 7, 2024 •
edited
Loading

The reworked #12753 includes a complex fix for this, but it's not a clean solution. As a temporary measure to fix the bug of not being allowed to cast spells, 9c52dfa makes ConditionalTargetAdjuster always satisfy the pre-activation target requirement.

Currently, it is less permissive than ideal, which is a major problem as it means that cards can not be played when they should be able to. An alternative possible fix is at #12842
@JayDi85 JayDi85 self-assigned this Sep 7, 2024
@JayDi85 JayDi85 added the refactoring Developers topics about code and programming label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JayDi85 JayDi85

Labels
refactoring Developers topics about code and programming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JayDi85 @ssk97