Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_version should only be incremented when there are sql scripts to run #128

Open
navarr opened this issue Jan 5, 2023 · 0 comments
Open

Comments

@navarr
Copy link

navarr commented Jan 5, 2023

From 1.4.2 to 1.4.3, the setup_version also increased from 1.4.2 -> 1.4.3.

This version indicates a change in the InstallSchema/UpgradeSchema/InstallData/UpgradeData scripts. This version should only be incremented when such scripts change.

There was no change in those scripts from 1.4.2 to 1.4.3. A change in the setup_version number without a change in the setup scripts means that a database upgrade must be performed, requiring downtime of the Magento store (even when there are no changes necessary - even in zero-downtime deployment systems).

Please update your processes so that setup_version only increases when one of the mentioned scripts is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant