Considering removing doctrine/annotations as dependency

[hostep]

Summary

See doctrine/annotations#485, the package will get abandonned.

We should figure out why Magento depends on this package and then see how to handle this...

Examples

Magento depends on this package:

magento2/composer.json

Line 43 in 3cc15fb

"doctrine/annotations": "^1.13",

It looks like in a fresh Magento 2.4.6-p2 the module is included because of:

$ composer why doctrine/annotations
allure-framework/allure-php-commons           v2.3.1   requires doctrine/annotations (^1.12 || ^2)
magento/magento2-functional-testing-framework 4.3.4    requires doctrine/annotations (^1.13)
magento/product-community-edition             2.4.6-p2 requires doctrine/annotations (^1.13)

It was added as direct dependency by ff461e6 (in my opinion this should have been added as a dev requirement...)

So it sounds like the MFTF code needs it at this moment and it sounds like nothing in core-Magento needs it...

Proposed solution

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @hostep. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @hostep,

Thanks for the report and collaboration!

I agree with your point, we need to remove the doctrine/annotations as a dependency due to it may be flagged as abandoned.

Hence confirming the issue.

Thanks

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9477 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[hostep]

It looks like this was partially solved by ef2c90f

The module still comes in through these 2 depencencies though:

$ composer2 why doctrine/annotations
allure-framework/allure-php-commons           v2.3.1 requires doctrine/annotations (^1.12 || ^2)
magento/magento2-functional-testing-framework 4.6.1  requires doctrine/annotations (^2.0)

The good thing is that both of these are dev dependencies, so it's at least no longer being installed in production environments...

Not sure if we can consider this ticket handled, or if further work is still needed in magento/magento2-functional-testing-framework for example?

[hostep]

It looks like it's now also removed from magento/magento2-functional-testing-framework via magento/magento2-functional-testing-framework@1385ef6

Let me close this issue then, it seems like we're getting there :)