Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 9 compatibility #71

Open
magro opened this issue Dec 27, 2016 · 8 comments
Open

Java 9 compatibility #71

magro opened this issue Dec 27, 2016 · 8 comments

Comments

@magro
Copy link
Owner

magro commented Dec 27, 2016

Some serializers might suffer from the issue described in cglib/cglib#93

@ddukki
Copy link

ddukki commented Jul 24, 2017

Looks like even with the core serializers, there is at least a warning. Is there a plan for moving away from the "illegal" reflections access?

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.esotericsoftware.kryo.util.UnsafeUtil (file:/C:/Users/user/.m2/repository/com/esotericsoftware/kryo/kryo/2.24.0/kryo-2.24.0.jar) to constructor java.nio.DirectByteBuffer(long,int,java.lang.Object)
WARNING: Please consider reporting this to the maintainers of com.esotericsoftware.kryo.util.UnsafeUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

@magro
Copy link
Owner Author

magro commented Mar 18, 2018

See also EsotericSoftware/kryo#543

@RobertSermak
Copy link

Hi there,
any chance that this warning "Illegal reflective access by com.esotericsoftware.kryo.util.UnsafeUtil" will be fixed?

@magro
Copy link
Owner Author

magro commented Oct 21, 2018

@RobertSermak this is not caused by kryo-serializers but kryo itself, see EsotericSoftware/kryo#543

@lantian
Copy link

lantian commented Jan 13, 2019

Hi,

And what with:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by de.javakaffee.kryoserializers.UnmodifiableCollectionsSerializer to field java.util.Collections$UnmodifiableCollection.c
WARNING: Please consider reporting this to the maintainers of de.javakaffee.kryoserializers.UnmodifiableCollectionsSerializer
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

? (openjdk 11).

@magro
Copy link
Owner Author

magro commented Jan 13, 2019

@lantian At least that's just a warning and it should still work, right?

Getting rid of this would require quite some effort with a java9+ specific implementation and multi-release jars - at least to my current understanding of this stuff. PRs are of course welcome ;-)

@lantian
Copy link

lantian commented Jan 13, 2019

@magro Yep, just a warning. But can be a problem (blocker) in future java releases.

As you said - this will require some effort to support jdk+ specific stuff.
It seems to me, that no one will do this better, then you ;)

Of course if you will have no time until blocker releases - we(community, maybe me, maybe someone) could create the PR.

@marcphilipp
Copy link

Any updates? Is it really necessary to use reflection for this?

@magro If you could outline a potential fix I might be able to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants