Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing red tests, possibly with exceptions #88

Closed
dewaldabrie opened this issue Apr 26, 2018 · 1 comment
Closed

Failing red tests, possibly with exceptions #88

dewaldabrie opened this issue Apr 26, 2018 · 1 comment

Comments

@dewaldabrie
Copy link

Hi,
Thank you for this great plugin, I'm finding it very useful for quality assurance on tests.
I would like to put in a feature request for having an option to fail tests if they exceed the warning threshold.

In other words, 'red' or 'error' classifications will be failed with an error message like "All the assertions in this test passed, but the test itself was slower than the allowed threshold of seconds".

Along with this, it would be nice to have the option to pass in the python path of certain tests that should be excluded from failing based on time. For example parameters like
--ignore-time-for-test=tests.MyTestClass.test_this --ignore-time-for-test=tests.MyTestClass2.test_this2
This would be useful if we have a good reason why some tests should run for longer than the normal threshold.

I would be happy to make contributions to implement the above.

@mahmoudimus
Copy link
Owner

@dewaldabrie thanks for the nice comments. If you wanted to take a stab at it, that would be great. See #87 #80 and the various proposals. I'm going to CC @skudriashev for knowledge sharing as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants