Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APIs for register mutation no longer return the fee charged for the operation #2449

Open
happybeing opened this issue Nov 17, 2024 · 1 comment

Comments

@happybeing
Copy link
Contributor

The earlier API returned details of the fee paid for register create and mutate and I think this is important for an app.

I suggest the return values for client::registers::register_create() and register_update() should include the fee charged.

@loziniak
Copy link
Contributor

loziniak commented Nov 22, 2024

In Client::register_create() fees are returned by using UploadSummary and mechanism mentioned by me in #2329 . See line 357 of registers.rs, function register_create_with_permissions() And when register is updated, perhaps the fees are not taken at all? I recall, that there were informations, that also updates are going to be paid, but maybe it's still the old way, pay once on register creation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants