Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional contract testing and logging #2608

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

mickvandijke
Copy link
Contributor

No description provided.

@mickvandijke mickvandijke force-pushed the stable-updated-contract-with-cli-fix branch from a8ab94a to ac11593 Compare January 7, 2025 14:20
@mickvandijke mickvandijke changed the title Stable updated contract with cli fix Additional contract testing and logging Jan 7, 2025
Copy link
Member

@grumbach grumbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent one! LGTM

/// Timeout for transactions
const TX_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(60);
const ARBITRUM_SEPOLIA_TEST_DATA_PAYMENTS_ADDRESS: Address =
address!("7f0842a78f7d4085d975ba91d630d680f91b1295");

Check failure

Code scanning / devskim

A token or key was found in source code. If this represents a secret, it should be moved somewhere else.

Do not store tokens or keys in source code.
@mickvandijke mickvandijke force-pushed the stable-updated-contract-with-cli-fix branch from ac11593 to ef35c1b Compare January 7, 2025 14:40
@mickvandijke mickvandijke enabled auto-merge January 7, 2025 14:46
@mickvandijke mickvandijke added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 6a84806 Jan 7, 2025
26 checks passed
@mickvandijke mickvandijke deleted the stable-updated-contract-with-cli-fix branch January 7, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants