Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing files on Patter #12

Open
Sascha-1 opened this issue Dec 20, 2018 · 5 comments
Open

Sharing files on Patter #12

Sascha-1 opened this issue Dec 20, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@Sascha-1
Copy link

When I go to
safe://patter.dapp/#/home
I seem to be able to share a .jpg file, but not a .mp3 file.

@bochaco
Copy link
Contributor

bochaco commented Dec 20, 2018

Thanks a lot @Sascha-1 for reporting it, we'll take a look and try to fix it.

@bochaco bochaco added the bug Something isn't working label Dec 20, 2018
@hunterlester
Copy link

hunterlester commented Dec 20, 2018

@Sascha-1 Thank you for testing. Which part of the process does not work? Is it when you attempt to upload the file? Is it when you attempt to view the file?

I just tested and I'm able to upload an mp4 but I can't view due to this safe_browser issue.

@bochaco
Copy link
Contributor

bochaco commented Dec 20, 2018

I'm wondering if it has to do with the file size @hunterlester @Sascha-1
Can you please share what the filesize is of the mp3 file you were trying with @Sascha-1 ?

@Sascha-1
Copy link
Author

Sorry for taking so long to respond. I've had some personal computer problems.

I tried sharing the attached file to @bochaco 's Patter, but the post just disappears. It's a 6.9 MB .mp3.
However, if I zip the file to 6.8 MB the attachment goes through. I'm attaching the zipped version here. Please remove it if you think attaching it was a bad idea.

05.I shall be free N 10.mp3.zip

@bochaco
Copy link
Contributor

bochaco commented Dec 28, 2018

thanks a lot @Sascha-1 , I just gave it a try and it's simply because the mime type audio/mpeg is not in the list of supported types in the multicodec project (https://github.com/bochaco/js-multicodec/blob/mime-types-as-codecs/src/base-table.js#L466).

We should probably add it to the list, but I also see a problem in Patter which is faiiing when trying to fallback to storing it without a mime type. It seems to be a problem in the ImmD close function which invalidates the cipherOpt object used even if it failed due to an invalid mime type provided, as I see this error thrown after retrying (https://github.com/maidsafe/safe-patter-js/blob/master/src/actions/user_actions.js#L262) with "null" as mime type: -1010: Invalid Self Encryptor handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants