Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create handler to get message envelopes #542

Closed
6 tasks
robdefeo opened this issue Feb 6, 2020 · 0 comments · Fixed by #604
Closed
6 tasks

Create handler to get message envelopes #542

robdefeo opened this issue Feb 6, 2020 · 0 comments · Fixed by #604
Labels
cmd/receiver enhancement New feature or request

Comments

@robdefeo
Copy link
Member

robdefeo commented Feb 6, 2020

Is your feature request related to a problem? Please describe.
cmd/envelopes will return envelopes based on an address, it should use the transactions.go in cmd/internal/datastore ref #515

Describe the solution you'd like

  • implement the method as defined in create GET messages method definition #530
  • use the datastore.Transactions to search for addresses against an address
  • order transactions to return by block to descending
  • use datastore.Transactions interface as parameter to handler creation
  • return status 200 for not found public key, see cmd/mailchain/internal/http/handlers/resolve_name.go
  • create unit tests
@robdefeo robdefeo added enhancement New feature or request cmd/receiver labels Feb 6, 2020
@stale stale bot added the Stale label Jun 5, 2020
@robdefeo robdefeo removed the Stale label Feb 7, 2021
@mailchain mailchain deleted a comment from stale bot Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/receiver enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant