New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash ephemeral key #657

Open

robdefeo opened this issue Feb 7, 2021 · 0 comments

Labels

area/crypto crypto/nacl enhancement security

Member

robdefeo commented Feb 7, 2021

Is your feature request related to a problem? Please describe.
Ephemeral key is not hashed in https://github.com/mailchain/mailchain/blob/f85c09ea74722525db86ce90aac433a9e729af6f/crypto/cipher/nacl/encrypter.go#L32 This is because if it is not hashed, we do not know how to prove any security property and there may be attacks against the scheme.

Describe the solution you'd like
Libsodium provides an example https://github.com/jedisct1/libsodium/blob/master/src/libsodium/crypto_box/curve25519xsalsa20poly1305/box_curve25519xsalsa20poly1305.c#L45

robdefeo added enhancement security crypto/nacl area/crypto labels

robdefeo mentioned this issue

Deprecate non hashed version of nacl encryption #658

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment