-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add temporary email description #6001
Open
marekfilip
wants to merge
3
commits into
mailcow:staging
Choose a base branch
from
marekfilip:feat/temp-email-aliases
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerLinkman
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
The rest for me looks fine, but i will request a review from @FreddleSpl0it too. |
DerLinkman
requested changes
Aug 13, 2024
marekfilip
force-pushed
the
feat/temp-email-aliases
branch
from
August 13, 2024 07:28
c85661d
to
d5d043c
Compare
FreddleSpl0it
requested changes
Aug 15, 2024
FreddleSpl0it
approved these changes
Sep 3, 2024
marekfilip
force-pushed
the
feat/temp-email-aliases
branch
from
September 13, 2024 09:53
23e7032
to
3c29af6
Compare
Changes rebased on latest staging to resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows user to define a description when creating a temporary email, it was requested in issue #4407.