Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandoned dependency: rest-client abandoned in 2019 #287

Open
jaredbeck opened this issue May 31, 2023 · 9 comments
Open

Abandoned dependency: rest-client abandoned in 2019 #287

jaredbeck opened this issue May 31, 2023 · 9 comments
Assignees

Comments

@jaredbeck
Copy link
Contributor

This project depends on the rest-client gem. Unfortunately, rest-client has been abandoned. There haven't been any commits since 2019.

There are some unofficial forks but it might be better to switch to something modern and maintained like Faraday.

@Earlopain
Copy link
Contributor

Hi @Retttro / @mgrishko, I'm interested in seeing this resolved. Would you accept a PR switching out rest-client with faraday? There's already a wrapper class around responses with Mailgun::Response so backwards compatibility issues on that front should be minimal, if any.

One somewhat unfortunate consequence of this change is that faraday 2.x requires ruby 2.6 at the minimum and would requires this gem to bump its minimal supported ruby version from 2.2 to 2.6 as well. Ruby 2.5 is EOL since 31 Mar 2021, so almost 3 years now.

Alternatively, I could explore going with plain Net::HTTP which doesn't have this problem. It's not great to use in any way but should get the job done. One sore point in net-http itself is multipart requests (as in no support at all). There's multipart-post but I'd rather not include for this in a gem that others depend on. You get to the situation we are at here where every gem includes different http gems and the consumer suddenly has 10 different ones in their lockfile.

Personally I would much appreciate the possibility of going with faraday just so that I wouldn't have to interact with net-http directly.

@Retttro
Copy link
Contributor

Retttro commented Dec 18, 2023

Hi @Earlopain. Thanks for your notes on this issue. I'm planning to make a PR with the transition to Faraday next month. I think we will release this at the end of January.

@Earlopain
Copy link
Contributor

Thanks for the quick response, I'm looking forward to that (:

@andreyzhelnin-st
Copy link

@Retttro Do you have any updates on this?

@Earlopain
Copy link
Contributor

It looks like Retttro doesn't work for/with mailgun anymore, if LinkedIn is to be believed. @mgrishko, can you give some insight here?

@mgrishko
Copy link
Collaborator

@Earlopain over the next 1-2 months, I'll be making these fixes.

@mgrishko mgrishko self-assigned this Apr 10, 2024
@n-rodriguez
Copy link
Contributor

@mgrishko Hi there! Any news?

@KoenSengers
Copy link

@mgrishko any progress on this topic?

@mgrishko
Copy link
Collaborator

mgrishko commented Oct 7, 2024

Still work in progress, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants