Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting max age in FastBoot #483

Open
bobisjan opened this issue Sep 16, 2020 · 0 comments
Open

Setting max age in FastBoot #483

bobisjan opened this issue Sep 16, 2020 · 0 comments

Comments

@bobisjan
Copy link

Hi,

I have question regarding max age in FastBoot, https://github.com/simplabs/ember-cookies/blob/master/addon/services/cookies.js#L139 converts from seconds to milliseconds, but maxAge is defined in seconds, see Set-Cookie header.

Does this look like a bug, thus the conversion should be removed? (If yes, I'm happy to submit PR)

Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobisjan