Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to enter custom gcode in the "Pause at layer" dialog. #1944

Open
miklschmidt opened this issue Jul 15, 2024 · 4 comments
Open

Ability to enter custom gcode in the "Pause at layer" dialog. #1944

miklschmidt opened this issue Jul 15, 2024 · 4 comments
Labels
💡 Type: FR Requests a new feature

Comments

@miklschmidt
Copy link

miklschmidt commented Jul 15, 2024

Requested feature:

Since the macro used for this feature supports custom gcode macros, it would be ideal if the dialog allowed the user to input a custom macro / gcode command instead of only picking between M600 and PAUSE.

This could either be achieved by changing the select box to a combobox/autocomplete which accepts custom text input and suggests M600 / PAUSE by default, or by adding a "Custom" option and showing a text input based on the selection of that item.

image

Solves the following problem:

  • Provides access to existing functionality
  • Flexible support for multiple use cases including:
    • Remapping toolheads / filaments at certain layer heights on MMU / IDEX systems after the fact.
    • Turning on/off any aux fans or chamber filter fans
    • Taking pictures
    • Cancelling a print at a certain layer height
    • Calling moonraker agent methods, for example push notifications to come back to the print to watch a tricky part of the process.
    • Reducing or increasing chamber temperature
      etc. etc.

Additional information:

The idea is to provide ample opportunity for the user to "save a print" if he forgets to add these during slicing, or is printing the same sliced file but needs an escape hatch at a certain layer.

In the future (not a requirement , just extra "icing on the cake" so to speak, the existing functionality already accounts for a vast array of use cases), it could even allow multiple entries, alas that would require changes to the mainsail klipper macros, so i suggest tabling that for now. Added #1945 to track this separately.

@miklschmidt miklschmidt added the 💡 Type: FR Requests a new feature label Jul 15, 2024
@meteyou
Copy link
Member

meteyou commented Jul 15, 2024

Thx for creating the FR.

pls also open a second FR with this feature:

In the future (not a requirement , just extra "icing on the cake" so to speak, the existing functionality already accounts for a vast array of use cases), it could even allow multiple entries, alas that would require changes to the mainsail klipper macros, so i suggest tabling that for now.

Just when I merge the PR for this FR, this information will be "lost", because the ticket is closed.

@miklschmidt
Copy link
Author

@meteyou done! #1945

@XScorpion2
Copy link

This is Xulkal on the RatRig discord.
I'm available if you need someone to test out these features before landing.
Depending on my schedule, I might try implementing this and putting up a pr for review, but not holding my breath this week due to family matters.

@meteyou
Copy link
Member

meteyou commented Jul 15, 2024

hey @XScorpion2!

at the moment i have to finish 2-3 things before i can start with this FR. so i probably won't get to these FR until next week. If you are interested, you are welcome to contribute this FR. i would be very happy about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Type: FR Requests a new feature
Projects
None yet
Development

No branches or pull requests

3 participants