Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to newer github action components to avoid deprecation warnings #319

Closed
agalbachicar opened this issue Apr 30, 2024 · 4 comments
Closed
Assignees

Comments

@agalbachicar
Copy link
Collaborator

agalbachicar commented Apr 30, 2024

Desired behavior

Most of the actions/checkout, actions/upload-artifact and alike components are pinned to the latest v3 version. We need to move to v4 to avoid deprecation warnings related to Node.js.

Alternatives considered

N/A

Implementation suggestion

N/A

Additional context

See https://github.com/maliput/maliput_py/actions/runs/7782058733 for example.

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Due date: 2024/06/30

@agalbachicar agalbachicar self-assigned this Apr 30, 2024
@agalbachicar
Copy link
Collaborator Author

agalbachicar commented May 8, 2024

@agalbachicar
Copy link
Collaborator Author

agalbachicar commented May 8, 2024

Making use of the occasion to update other actions as well:

  • actions/checkout@v4
  • actions/upload-artifact@v4
  • ros-tooling/[email protected] --> it didn't work, I need to keep it in v0.6
  • codecov/codecov-action@v4
  • docker/login-action@v3
  • docker/metadata-action@v5
  • docker/build-push-action@v5
  • softprops/action-gh-release@v2
  • ros-tooling/[email protected]
  • actions/setup-python@v5
  • actions/deploy-pages@v4
  • actions/upload-pages-artifact@v3
  • actions/add-to-project@v1

@agalbachicar
Copy link
Collaborator Author

Curiously, all workflows using the manylinux image failed. That is related to a glibc library version installed in the image which collides with a node dependency required by actions/checkout@v4. Seems like sticking to v3 for now is the only way moving forward.

In particular, the manylinux image has glibc-2.17-326.el7_9.x86_64 and the requirement is for glibc 2.25+.

@agalbachicar agalbachicar changed the title Migrate to v4 github action components to avoid deprecation warnings Migrate to newer github action components to avoid deprecation warnings May 13, 2024
@francocipollone
Copy link
Collaborator

Curiously, all workflows using the manylinux image failed. That is related to a glibc library version installed in the image which collides with a node dependency required by actions/checkout@v4. Seems like sticking to v3 for now is the only way moving forward.

In particular, the manylinux image has glibc-2.17-326.el7_9.x86_64 and the requirement is for glibc 2.25+.

Until November 30, 2024 we are ok: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants