Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matches_the_pg_string isn't unit tested #45

Open
malsyned opened this issue Oct 25, 2017 · 0 comments
Open

matches_the_pg_string isn't unit tested #45

malsyned opened this issue Oct 25, 2017 · 0 comments

Comments

@malsyned
Copy link
Owner

malsyned commented Oct 25, 2017

If matches_the_pg_string_test() was rewritten to simply "return true", the test suite would still pass and many of the tests in the self-test suite could be in error. While it is easy to catch errors in this test while adding new self-tests (greens would show up when the developer is expecting reds), refactoring in pfstest-matchers.c could result in this function breaking silently until the problem is discovered while adding new self-tests, if ever.

@malsyned malsyned changed the title matches_the_nv_string isn't unit tested matches_the_pg_string isn't unit tested Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant