You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If matches_the_pg_string_test() was rewritten to simply "return true", the test suite would still pass and many of the tests in the self-test suite could be in error. While it is easy to catch errors in this test while adding new self-tests (greens would show up when the developer is expecting reds), refactoring in pfstest-matchers.c could result in this function breaking silently until the problem is discovered while adding new self-tests, if ever.
The text was updated successfully, but these errors were encountered:
malsyned
changed the title
matches_the_nv_string isn't unit tested
matches_the_pg_string isn't unit tested
Oct 26, 2017
If matches_the_pg_string_test() was rewritten to simply "return true", the test suite would still pass and many of the tests in the self-test suite could be in error. While it is easy to catch errors in this test while adding new self-tests (greens would show up when the developer is expecting reds), refactoring in pfstest-matchers.c could result in this function breaking silently until the problem is discovered while adding new self-tests, if ever.
The text was updated successfully, but these errors were encountered: