Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue in SmallThreadingDetector #158

Open
lab3 opened this issue Apr 6, 2024 · 2 comments
Open

Potential issue in SmallThreadingDetector #158

lab3 opened this issue Apr 6, 2024 · 2 comments

Comments

@lab3
Copy link

lab3 commented Apr 6, 2024

Worlds hanging and crashing on chunkgen in SmallThreadingDetector

This operation seems like it shouldn't really cause any side effects. Any idea what might be going on?

https://github.com/iron431/irons-spells-n-spellbooks/blob/1.20.1/src/main/java/io/redspace/ironsspellbooks/worldgen/RemoveWaterProcessor.java

CrashLog
message (1).txt

@malte0811
Copy link
Owner

Is this reproducible? The threading detector optimization is disabled by default because of issues like this, but I have no idea why my implementation should behave differently from the vanilla one (despite going through both implementations very carefully multiple times). If I had a reproducible test case that would make debugging much easier.

In any case it is very unlikely that this is caused by the code you linked.

@lab3
Copy link
Author

lab3 commented Apr 10, 2024

Ok. Thanks. I'll see if I can get something reproducible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants