From 217fc5e95ca8cd6c70bcef878e5e32bfc9ecb43f Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Mon, 23 Oct 2017 01:57:16 +0200 Subject: [PATCH 1/3] Add link to get to mammooc more quickly and view there all evaluations --- src/mammooc-course-evaluation.html | 13 +++++++++++++ src/mammooc-localize-behavior.html | 12 ++++++++---- src/mammooc-rating-widget.html | 6 +----- 3 files changed, 22 insertions(+), 9 deletions(-) diff --git a/src/mammooc-course-evaluation.html b/src/mammooc-course-evaluation.html index 52addc258..ee74a146e 100644 --- a/src/mammooc-course-evaluation.html +++ b/src/mammooc-course-evaluation.html @@ -25,6 +25,14 @@ --iron-icon-width: 20px; } + .heading { + display:inline; + } + + a { + color: var(--mammooc-rating-widget-primary-color, #ffac33); + } + .evaluations > iron-scroll-threshold { max-height: 200px; overflow-y: scroll; @@ -98,6 +106,7 @@
{{localize("courseevaluations")}}
+ {{localize("seeall")}}
@@ -183,6 +192,10 @@ super.ready(); } + _generateCourseUrl(provider, courseId) { + return 'https://mammooc-dev.herokuapp.com/courses/' + provider + '~' + courseId; + } + _generateEvaluationUrl(provider, courseId, perPage, page) { return 'https://mammooc-dev.herokuapp.com/evaluations/export_course_evaluations?provider=' + provider + '&course_id=' + courseId + '&page=' + page + '&per_page=' + perPage; } diff --git a/src/mammooc-localize-behavior.html b/src/mammooc-localize-behavior.html index 6d43d3b85..098a52230 100644 --- a/src/mammooc-localize-behavior.html +++ b/src/mammooc-localize-behavior.html @@ -43,7 +43,8 @@ 'submit': 'Submit', 'descriptionplaceholder': 'The course was...', 'descriptionlabel': 'Your course evaluation', - 'successtext': 'Your evaluation was successfully saved.' + 'successtext': 'Your evaluation was successfully saved.', + 'seeall': 'See all' }, 'de': { 'noevaluations': 'Noch keine Evaluierungen', @@ -59,7 +60,8 @@ 'submit': 'Abschicken', 'descriptionplaceholder': 'Der Kurs war...', 'descriptionlabel': 'Deine Kurs-Evaluierung', - 'successtext': 'Deine Evaluierung wurde erfolgreich gespeichert.' + 'successtext': 'Deine Evaluierung wurde erfolgreich gespeichert.', + 'seeall': 'Alle anzeigen' }, 'fr': { 'noevaluations': 'Aucun Evaluation', @@ -75,7 +77,8 @@ 'submit': 'Soumettre', 'descriptionplaceholder': 'Le cours a été...', 'descriptionlabel': 'Votre évaluation du cours…', - 'successtext': 'Votre évaluation a été sauvegarder avec succès.' + 'successtext': 'Votre évaluation a été sauvegarder avec succès.', + 'seeall': 'Voir tous' }, 'zh': { 'noevaluations': ' 暂无评价', @@ -91,7 +94,8 @@ 'submit': '提交', 'descriptionplaceholder': '该课程…', 'descriptionlabel': '您的课程评价', - 'successtext': '已成功保存您的评价。' + 'successtext': '已成功保存您的评价。', + 'seeall': '查看全部' } }; } diff --git a/src/mammooc-rating-widget.html b/src/mammooc-rating-widget.html index 787546f07..df057fec2 100644 --- a/src/mammooc-rating-widget.html +++ b/src/mammooc-rating-widget.html @@ -99,7 +99,7 @@
- {{localize("poweredby")}} mammooc + {{localize("poweredby")}} mammooc
@@ -183,10 +183,6 @@ return 'https://mammooc-dev.herokuapp.com/evaluations/export_overall_course_rating?provider=' + provider + '&course_id=' + courseId; } - _generateCourseUrl(provider, courseId) { - return 'https://mammooc-dev.herokuapp.com/courses/' + provider + '~' + courseId; - } - _handleRatingResponse(request) { const evaluation = request.detail.response.evaluations; From 2d4ebe36c9ebb0b3a453e2e591e99f872cb61425 Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Mon, 23 Oct 2017 01:57:30 +0200 Subject: [PATCH 2/3] Change scheme from HTTP to HTTPS --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4f98f1e53..5a2b58d3a 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # mammooc-rating-widget Widget to provide ratings and evaluations from mammmooc.org to other platforms. For documentation and a demo visit: -http://mammooc.github.io/mammooc-rating-widget/ +https://mammooc.github.io/mammooc-rating-widget/ Feel free to contribute to the project! From 8d3b2b80252a961200c61e02ce86c7a2ab386afe Mon Sep 17 00:00:00 2001 From: Sebastian Serth Date: Mon, 23 Oct 2017 02:04:31 +0200 Subject: [PATCH 3/3] Update analysis.json --- analysis.json | 128 +++++++++++++++++++++++++------------------------- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/analysis.json b/analysis.json index 509977f5a..69003b150 100644 --- a/analysis.json +++ b/analysis.json @@ -134,11 +134,11 @@ "privacy": "protected", "sourceRange": { "start": { - "line": 132, + "line": 141, "column": 20 }, "end": { - "line": 135, + "line": 144, "column": 21 } }, @@ -154,11 +154,11 @@ "privacy": "public", "sourceRange": { "start": { - "line": 140, + "line": 149, "column": 20 }, "end": { - "line": 142, + "line": 151, "column": 21 } }, @@ -173,11 +173,11 @@ "privacy": "public", "sourceRange": { "start": { - "line": 147, + "line": 156, "column": 20 }, "end": { - "line": 149, + "line": 158, "column": 21 } }, @@ -192,11 +192,11 @@ "privacy": "public", "sourceRange": { "start": { - "line": 154, + "line": 163, "column": 20 }, "end": { - "line": 156, + "line": 165, "column": 21 } }, @@ -211,11 +211,11 @@ "privacy": "public", "sourceRange": { "start": { - "line": 161, + "line": 170, "column": 20 }, "end": { - "line": 163, + "line": 172, "column": 21 } }, @@ -230,11 +230,11 @@ "privacy": "protected", "sourceRange": { "start": { - "line": 165, + "line": 174, "column": 20 }, "end": { - "line": 168, + "line": 177, "column": 21 } }, @@ -250,11 +250,11 @@ "privacy": "protected", "sourceRange": { "start": { - "line": 170, + "line": 179, "column": 20 }, "end": { - "line": 173, + "line": 182, "column": 21 } }, @@ -271,28 +271,52 @@ "privacy": "protected", "sourceRange": { "start": { - "line": 181, + "line": 190, "column": 12 }, "end": { - "line": 183, + "line": 192, "column": 13 } }, "metadata": {}, "params": [] }, + { + "name": "_generateCourseUrl", + "description": "", + "privacy": "protected", + "sourceRange": { + "start": { + "line": 194, + "column": 12 + }, + "end": { + "line": 196, + "column": 13 + } + }, + "metadata": {}, + "params": [ + { + "name": "provider" + }, + { + "name": "courseId" + } + ] + }, { "name": "_generateEvaluationUrl", "description": "", "privacy": "protected", "sourceRange": { "start": { - "line": 185, + "line": 198, "column": 12 }, "end": { - "line": 187, + "line": 200, "column": 13 } }, @@ -318,11 +342,11 @@ "privacy": "protected", "sourceRange": { "start": { - "line": 189, + "line": 202, "column": 12 }, "end": { - "line": 195, + "line": 208, "column": 13 } }, @@ -335,11 +359,11 @@ "privacy": "protected", "sourceRange": { "start": { - "line": 197, + "line": 210, "column": 12 }, "end": { - "line": 209, + "line": 222, "column": 13 } }, @@ -356,11 +380,11 @@ "privacy": "protected", "sourceRange": { "start": { - "line": 211, + "line": 224, "column": 12 }, "end": { - "line": 217, + "line": 230, "column": 13 } }, @@ -380,11 +404,11 @@ "privacy": "protected", "sourceRange": { "start": { - "line": 219, + "line": 232, "column": 12 }, "end": { - "line": 229, + "line": 242, "column": 13 } }, @@ -401,11 +425,11 @@ "metadata": {}, "sourceRange": { "start": { - "line": 122, + "line": 131, "column": 8 }, "end": { - "line": 230, + "line": 243, "column": 9 } }, @@ -418,11 +442,11 @@ "description": "The provider of the course, e.g. \"openHPI\"", "sourceRange": { "start": { - "line": 140, + "line": 149, "column": 20 }, "end": { - "line": 142, + "line": 151, "column": 21 } }, @@ -434,11 +458,11 @@ "description": "The ID of the course in the provider's system", "sourceRange": { "start": { - "line": 147, + "line": 156, "column": 20 }, "end": { - "line": 149, + "line": 158, "column": 21 } }, @@ -450,11 +474,11 @@ "description": "The number of items shown per page", "sourceRange": { "start": { - "line": 154, + "line": 163, "column": 20 }, "end": { - "line": 156, + "line": 165, "column": 21 } }, @@ -466,11 +490,11 @@ "description": "The number of ratings in general", "sourceRange": { "start": { - "line": 161, + "line": 170, "column": 20 }, "end": { - "line": 163, + "line": 172, "column": 21 } }, @@ -1019,41 +1043,17 @@ } ] }, - { - "name": "_generateCourseUrl", - "description": "", - "privacy": "protected", - "sourceRange": { - "start": { - "line": 185, - "column": 12 - }, - "end": { - "line": 187, - "column": 13 - } - }, - "metadata": {}, - "params": [ - { - "name": "provider" - }, - { - "name": "courseId" - } - ] - }, { "name": "_handleRatingResponse", "description": "", "privacy": "protected", "sourceRange": { "start": { - "line": 189, + "line": 185, "column": 12 }, "end": { - "line": 196, + "line": 192, "column": 13 } }, @@ -1079,7 +1079,7 @@ "column": 8 }, "end": { - "line": 197, + "line": 193, "column": 9 } }, @@ -1193,7 +1193,7 @@ "column": 4 }, "end": { - "line": 100, + "line": 104, "column": 5 } },