-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed suboptimal usage of ipywidgets.Output widget #143
base: master
Are you sure you want to change the base?
Conversation
Hi @norweeg |
I suspect that these tests are bad. The code was originally doing all the formatting of the output and manually writing it into the output buffer, which is extremely unnecessary and defeats the purpose of using the |
294247f
to
ff685a2
Compare
ff685a2
to
58c0080
Compare
58c0080
to
374b97f
Compare
Gently bumping this, since it hasn't seen activity in a while, and also happens to affects me. :) |
I will get back on this! I need to write tests, but a significant amount of the existing tests need to be reworked as they check values of internal attributes of the ipywidgets.Output class when the whole purpose of this PR is to get away from directly formatting and writing output, but rather allow the Output widget to perform that function for us |
@norweeg Thanks for the PR, and my sincere apologies for the delay. I do agree testing requires a revamp. Do you plan to work on this? |
Description of new feature, or changes
Fixes suboptimal usage of ipywidgets.Output in HaloNotebook. See Output's API documentation for more info.
resolves #140
resolves #59
Checklist
Related Issues and Discussions
People to notify