Create IgnorePartialOverlaps interface option and pass to the Cut algorithm
#901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
This PR creates an
IgnorePartialOverlapscheck box on the Cut interface, and its value gets passed through to the Cut algorithm. The ability to provide aIgnorePartialOverlapsoption via the command line is also available.It is not yet possible to provide this option for an interactive cut. This functionality will be added in a later PR. Remind me to create an issue for this.
This PR is currently waiting on a PR in the main mantid repo to be finished and merged.
To test:
When switching between the Rebin and Integration algorithms, check that
IgnorePartialOverlapsis default off for Rebin and default on for Integration.Fixes #835