memory leak in pacparser_find_proxy()

[manugarg]

From [email protected] on February 26, 2013 11:02:03

In pacparser-1.3.0, the function pacparser_find_proxy() in pacparser.c does a malloc of a "script" string and never frees it.  JS_EvaluateScript() must not free its parameter because just above that point it is called with a string constant instead of a malloced string.

Based on the fact that pacparser_just_find_proxy() does (in effect) a strdup() of the return value of pacparser_find_proxy(), I am assuming that the return value of the latter is freed by pacparser_cleanup().  It would be good to document the fact that the caller of pacparser_just_find_proxy() is responsible for freeing its returned string.

Original issue: http://code.google.com/p/pacparser/issues/detail?id=22

[manugarg]

From [email protected] on February 26, 2013 11:09:13

(No comment was entered for this change.)

[manugarg]

From manugarg on April 14, 2013 23:01:02

Patch committed as part of Issue 23 .

Status: Fixed