From cbe997a0950df0ce3e747ddbc90772b495d6506c Mon Sep 17 00:00:00 2001 From: Marc Nuri Date: Wed, 8 Jan 2025 16:00:22 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20revert:=20force=20native=20spell?= =?UTF-8?q?=20check=20until=20Electron=20issue=20is=20fixed=20(#464)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Marc Nuri --- src/settings/settings.spell-check.browser.mjs | 4 ---- src/spell-check/index.js | 8 +------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/settings/settings.spell-check.browser.mjs b/src/settings/settings.spell-check.browser.mjs index 609be9a8..8ec73dcc 100644 --- a/src/settings/settings.spell-check.browser.mjs +++ b/src/settings/settings.spell-check.browser.mjs @@ -44,10 +44,6 @@ export const SpellCheckPane = ({dispatch, state}) => { checked=${useNative} onClick=${toggleProperty({dispatch, property: 'useNativeSpellChecker'})} /> -
-

NOTE: Currently, the Native Spell Checker is always used due to a bug in Electron:

-

electron/issues/44336

-
<${Card.Divider} />
${ Object.entries(dictionaries(state)) diff --git a/src/spell-check/index.js b/src/spell-check/index.js index 22fc7a63..40eab1dc 100644 --- a/src/spell-check/index.js +++ b/src/spell-check/index.js @@ -87,13 +87,7 @@ const getAvailableNativeDictionaries = () => const handleGetMisspelled = async (_event, words) => fakeRendererWorker.webContents.executeJavaScript(`getMisspelled(${JSON.stringify(words)})`); -const getUseNativeSpellChecker = () => { - // eslint-disable-next-line no-warning-comments - // TODO: always use native spellcheck until there's a fix for - // https://github.com/electron/electron/issues/44336 - return true; - // return loadSettings().useNativeSpellChecker; -}; +const getUseNativeSpellChecker = () => loadSettings().useNativeSpellChecker; const getEnabledDictionaries = () => loadSettings().enabledDictionaries;