From 333be1a680437ff872d60101f6c0c1839575be61 Mon Sep 17 00:00:00 2001 From: werrolf Date: Wed, 7 Oct 2020 06:41:10 +0200 Subject: [PATCH] [NFC] todos --- Component/Drivers/PostgreSQL.php | 1 + Component/FeatureType.php | 1 + 2 files changed, 2 insertions(+) diff --git a/Component/Drivers/PostgreSQL.php b/Component/Drivers/PostgreSQL.php index 591194c..e0df2b8 100644 --- a/Component/Drivers/PostgreSQL.php +++ b/Component/Drivers/PostgreSQL.php @@ -268,6 +268,7 @@ public function listTables($schemaName) * @internal param $wkt * @todo: null srid makes no sense, should throw an error * @todo: if an ewkt goes in, an ewkt should come out; native format is pretty useless outside of insert / update usage + * @todo: never produce dummy geometries; dummy geometries only produce collateral errors */ public function transformEwkt($ewkt, $srid = null) { diff --git a/Component/FeatureType.php b/Component/FeatureType.php index bc286af..15c3b68 100644 --- a/Component/FeatureType.php +++ b/Component/FeatureType.php @@ -222,6 +222,7 @@ protected function reloadItem($feature) * Extracts persistable values (insert / update) from Feature * Implicitly transforms the geometry to a compatible CRS. * @todo: do this with an SQL expression inside the insert / update query, instead of a separate SELECT + * @todo: make geometry valid on insert / update * * @param Feature $feature * @return mixed[]