Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster parameter does not respect prefixes #341

Open
michaelskahn opened this issue Jul 7, 2020 · 3 comments · May be fixed by #342
Open

Cluster parameter does not respect prefixes #341

michaelskahn opened this issue Jul 7, 2020 · 3 comments · May be fixed by #342

Comments

@michaelskahn
Copy link

I'm using the prefix option to deploy multiple watchbot services using a single CFN stack. This works fine for most parameters, but trying to set different values for the cluster results in an error:

Error: Outputs name used more than once: ClusterArn

The ClusterArn appears to be treated differently than the other options in that it isn't prefixed, so defining multiple watchbot services in a single template fails unless the cluster is always the same. Is having multiple clusters within a single stack something that watchbot can support?
@rclark
Copy link
Contributor

rclark commented Jul 7, 2020

That should be prefixed. Think you could put together a PR?

@michaelskahn
Copy link
Author

Sure. I can (I think) preserve existing behavior by setting an overall ClusterArn if and only if all clusters are the same. That avoids a breaking change for downstream consumers that may be relying on the current ClusterArn output value while setting prefixes.

@rclark
Copy link
Contributor

rclark commented Jul 8, 2020

Hm, I think that the lack of prefixed output here is a straight-up bug. Yes, it'd be a breaking change, but I think it is better to break the bugged behavior and make a new major version release.

@michaelskahn michaelskahn linked a pull request Jul 8, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply prefix to ClusterArn mapbox/ecs-watchbot
2 participants
@rclark @michaelskahn