Pass userProperties to midpoints and vertices #846
Comments
|
Just spent a bunch of time trying to figure out why userProperties had no effect on my midpoint/vertex layers, I guess this is why. I would greatly appreciate having support for userProperties on these layers. |
|
@drewbo Have you submitted a PR for this issue? I'd love a solution to this problem as well. |
|
Hello again, has there been any progress made regarding this? It would be really nice to get this functionality into Mapbox Draw. |
|
@helenezspeer, the pull request is being tracked here: #847 |
|
Just to throw some weight into this, it would be great to get this feature landed as without it I'm not sure there's a way to style custom midpoints and vertices. If the issue is not having an up-to-date PR I would potentially be able to take a look at updating @drewbo's PR here. |
|
Hi @JamesLMilner ! Yeah, if you could take a look that would be great; it was working at the time I wrote it (I used the fork for a separate project) but I think still probably needs to love to get up to date (although maybe @awulkan resolved) |
|
@JamesLMilner an updated PR would be great! |
|
@drewbo @asheemmamoowala thanks for your swift responses. A new PR sounds good to me, I will raise it as soon as I get a moment. |
|
@drewbo @asheemmamoowala I've raised this up to date with |
On creation of a midpoint or a vertex, the new feature is initialized with a reference to the parent feature but none of the properties are passed down. This means that midpoints and vertices can't be styled based on user-provided properties. I'd like to work up a PR where the user-provided properties are passed down to these features for potential styling. Thoughts?
Parent references:
mapbox-gl-draw/src/lib/create_vertex.js
Line 19 in 5b22808
mapbox-gl-draw/src/lib/create_midpoint.js
Line 24 in 5b22808
The text was updated successfully, but these errors were encountered: