Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement RouteProgress based on navigator status #2457

Open
1ec5 opened this issue Jul 14, 2020 · 0 comments
Open

Reimplement RouteProgress based on navigator status #2457

1ec5 opened this issue Jul 14, 2020 · 0 comments
Labels
op-ex Refactoring, Tech Debt or any other operational excellence work. topic: location

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jul 14, 2020

MapboxNavigationNative provides route progress statistics, but RouteController mostly ignores it in favor of the calculations in RouteProgress. At some point, we may want to migrate over to MapboxNavigationNative’s calculations for consistency.

MapboxNavigationNative ensure a consistent Earth radius or distance formula between MapboxNavigationNative and Valhalla. Currently, Core Navigation calculates and aggregates route progress statistics purely from the fields coming from the Directions API, which ensures consistency with the API whether the endpoint happens to be powered by Valhalla or OSRM (which may use different constants). Differences in Earth radius and distance formula have bitten us in the past, and there’s still some inconsistency on the client side: mapbox/turf-swift#26. Migrating to MapboxNavigationNative for this purpose will be a bit sad because RouteProgress is such a showcase for Swift functional programming – especially compared to the C++ that would replace it under the hood.

/cc @mapbox/navigation-ios

@1ec5 1ec5 added op-ex Refactoring, Tech Debt or any other operational excellence work. topic: location labels Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
op-ex Refactoring, Tech Debt or any other operational excellence work. topic: location
Projects
None yet
Development

No branches or pull requests

1 participant