Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label positioning is wrong on rooms that aren't perfectly square? #58

Closed
iomturner opened this issue Mar 24, 2020 · 2 comments
Closed

Comments

@iomturner
Copy link

iomturner commented Mar 24, 2020

@mourner if you remember I previously posted having issues with L shaped rooms (#55) where you told me to decrease the tolerance to 0.00001 . But now I noticed another issue with rooms that aren't perfectly square:

https://stackblitz.com/edit/mapbox-simple-map-cbnty5?file=index.ts

Screen Shot 2020-03-24 at 1 27 42 PM

not sure if this helps but i also posted this when i zoomed into the points:

Screen Shot 2020-03-24 at 1 39 38 PM

@iomturner iomturner reopened this Mar 24, 2020
@iomturner
Copy link
Author

iomturner commented Mar 25, 2020

i have noticed out of the two rooms/ squares. there are not 100% aligned into a rectangle... and with the tolerance level so low it off centers the label... sigh how do I get the labels center for complex shapes without lowing the tolerance too much that it becomes broken on rectangles not 100% aligned...

@mourner
Copy link
Member

mourner commented Mar 25, 2020

Duplicate of #33

@mourner mourner marked this as a duplicate of #33 Mar 25, 2020
@mourner mourner closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants