Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF message still prints with --quiet flag #961

Open
jdmcbr opened this issue Jan 14, 2023 · 2 comments
Open

EOF message still prints with --quiet flag #961

jdmcbr opened this issue Jan 14, 2023 · 2 comments

Comments

@jdmcbr
Copy link

jdmcbr commented Jan 14, 2023

I have geojson point datasets that I'm converting to tilesets. I've been seeing the "Reached EOF without all containers being closed" message that is referenced in #191, and understand that the messages can be safely ignored in my context. However, I was still interested in quieting those messages (so that I could more easily find the messages I do need to pay attention to), and the --quiet flag doesn't seem to be doing the trick.

$ tippecanoe --minimum-zoom=10 --maximum-zoom=15 --quiet --no-feature-limit --read-parallel points.geojson -o points.mbtiles
points.geojson:580: Reached EOF without all containers being closed
In JSON object {"type":"FeatureCollection","name":"points","crs":{"type":"name","properties":{"name":"urn:ogc:def:crs:OGC:1.3:CRS84"}},"features":[]}
points.geojson:574: Found ] at top level

Is this expected behavior? Perhaps this is considered an error, and not a warning, and thus still prints? Ideally tippecanoe would recognize the case described be @e-n-f in #191

If your file actually does have one feature per line, and just has a FeatureCollection around them, then the messages are harmless and just refer to one thread reaching the end of its input with the FeatureCollection it started parsing

and not print the message at all, but having the --quiet flag actually work would be nice if it isn't possible to recognize circumstances where the message is harmless.

Version:

~ $ tippecanoe --version
tippecanoe v1.36.0
@e-n-f
Copy link
Contributor

e-n-f commented Jan 14, 2023

Tippecanoe is now maintained at https://github.com/felt/tippecanoe

This message is the result of using the -P/--read-parallel flag on regular GeoJSON (as opposed to newline-delimited GeoJSON) input. I would recommend either not using parallel parsing, or formatting the input in a way that can be parsed in parallel without warnings.

@jdmcbr
Copy link
Author

jdmcbr commented Jan 14, 2023

Oh, thanks @e-n-f , I didn't notice any message about it having migrated to the felt organization before posting. Should I transfer this there?

I understood from the other thread that that was the recommended course. Parallel parsing provides a nice speedup though, and I haven't found how to format the input so as to avoid the warning without then rendering the geojson in ways that hinder its use in other applications. That's why I asked if it was expected for the --quiet flag not to actually quiet those messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants