Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot #826

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Add dependabot #826

merged 1 commit into from
Dec 17, 2023

Conversation

birkskyum
Copy link
Member

It has a low limit on how many PRs it's allowed to open at a time, so it should not flood the repo.

@birkskyum birkskyum requested a review from nyurik October 23, 2023 20:20
@nyurik nyurik merged commit 0c46aff into maplibre:master Dec 17, 2023
7 of 8 checks passed
@HarelM
Copy link
Collaborator

HarelM commented Dec 17, 2023

In maplibre-gl I've added some flows to automatically merge PRs from dependabot if they pass CI.
It requires setting a branch protection and setting CI runs as required, but it removes a lot of the manual work around upgrading dependencies.

@nyurik
Copy link
Member

nyurik commented Dec 17, 2023

Yeah, we should implement that too. I think there is tons of work to get this repo into a better state, such as testing, linting, better CI, local testing, updates to dockers, rename primary branch, and zillions of other things ;)

@HarelM
Copy link
Collaborator

HarelM commented Dec 17, 2023

Yup, the best way to solve this it to prioritize I believe.
For me the priorities are:

  1. Create an official release including npm + docker (currently there is only a pre-release) - assuming this is semi-automatic, otherwise make is easier to create a new release.
  2. Change default branch name to main
  3. Automate dependecies upgrade
  4. After most of the dependencies are up-to-date (hoping most of them don't have breaking changes) upgrade lint rules
  5. Other stuff...

@nyurik
Copy link
Member

nyurik commented Dec 17, 2023

sounds good to me! Thanks for looking into this!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants