-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt a standard layout for the repository that includes standard CI and api best practices #4
Comments
Adopt the project layout from pheval: https://github.com/monarch-initiative/pheval Sooner rather than layer, in particular, adopt these files:
|
Is the proposed layout related to the cookie cutter? Can you change the title, please? |
They are related - I changed the title; the point is to make a sane, standard repo structure with sane code style checking and integration testing, and a reasonably standard modular structure according to fastapi best practice |
I was thinking of creating a cookie cutter for reuse, but that is different. |
You can, if you like! But this is less of a priority here then adding standardising this specific repo. My suggestion would be to first create a perfect layout here, and then, once we are happy with all of its aspects, transform it into a cookie cutter for monarch fastapi development? |
Yes, entirely not the scope of this issue now and not previously. |
Looking into the LICENSE in the pheval repo, it's missing to replace this part:
What does it need to be in the SSSOM API repo? |
Can you ask this question in the |
https://github.com/tiangolo/full-stack-fastapi-postgresql
The text was updated successfully, but these errors were encountered: