Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up tests/data/validation_data #317

Open
matentzn opened this issue Sep 23, 2022 · 1 comment · May be fixed by #318
Open

Clean up tests/data/validation_data #317

matentzn opened this issue Sep 23, 2022 · 1 comment · May be fixed by #318
Assignees
@hrshdhgd

Comments

@matentzn
Copy link
Collaborator

There are quite a few JSON files in there which were from an ancient SSSOM version.

We should

  1. regenerate all the data in the tests/data/validation_data using the up-to-date sssom-py
  2. check that all tests still pass
@hrshdhgd hrshdhgd linked a pull request Sep 25, 2022 that will close this issue
Draft
@hrshdhgd
Copy link
Contributor

I removed all files from within validate_data dir and ran all tests. They pass! It seems like none of those files were used by any of the tests. check out #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hrshdhgd hrshdhgd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete all validation files since they may be old mapping-commons/sssom-py
2 participants
@hrshdhgd @matentzn