Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the API layer more conventional #376

Open
hrshdhgd opened this issue May 30, 2023 · 1 comment
Open

Make the API layer more conventional #376

hrshdhgd opened this issue May 30, 2023 · 1 comment
Assignees

Comments

@hrshdhgd
Copy link
Contributor

hrshdhgd commented May 30, 2023

For e.g.:
parse_file conventionally takes an input and returns object(s) but in our case, it takes a path, converts the data into SSSOM format and exports it (stdout or output file if path provided.).

Ref: Slack conversation with Chris.

@matentzn
Copy link
Collaborator

matentzn commented Jun 2, 2023

I agree, we should align the design here a bit with pandas.read_csv() etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants