Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix.Derivation: vendor parser #127

Closed

Conversation

ConnorBaker
Copy link

This PR vendors the parser component of https://github.com/Gabriella439/Haskell-Nix-Derivation-Library (specifically Sorki's fork with the changes in Gabriella439/Haskell-Nix-Derivation-Library#24) in an attempt to close #122.

Important

The code being vendored is licensed under BSD3, while this project is licensed under GPL3. I am not a lawyer and have no idea how to, or if it is even possible to, dual-license them.

As is likely apparent from my appeal to a higher power in the code

let
  storePath = case path of
    Nix.ContentAddressedDerivationOutput{} -> error "God help us all it's a content-addressed output"
    _ -> path.path
in

I don't know the best way to handle such a case. Perhaps just fail and don't print the output?

…rary fork

All credit goes to @sorki and @rickynils for their work on:

- Gabriella439/Haskell-Nix-Derivation-Library#26
- Gabriella439/Haskell-Nix-Derivation-Library#24

and of course to @Gabriella439 for the entire library!

This commit takes the changes relevant to `Nix.Derivation` and vendors them in-tree.

Co-Authored-By: Gabriella Gonzalez <[email protected]>
Co-Authored-By: sorki <[email protected]>
Co-Authored-By: Rickard Nilsson <[email protected]>
@ConnorBaker
Copy link
Author

Closed as not the right way to go about this: #122 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DerivationParseError around ca-derivations
1 participant