Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only patch subsequence of ONT read in consensus #68

Open
skoren opened this issue May 3, 2022 · 1 comment
Open

Use only patch subsequence of ONT read in consensus #68

skoren opened this issue May 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@skoren
Copy link
Member

skoren commented May 3, 2022

Right now, we do not split reads so the full ONT reads are included even if the patch is much shorter. This can lead to issues when the patch is near the ends of tigs. The long ONT reads will extend past the last HiFi read and generate low-quality ONT-only cns. It is also likely redundant (overlapping) with other tigs in the output that do have the HiFi reads. To address this, make consensus support subsequence coordinates for reads and only use the minimum needed ONT sequence (+ surrounding sequence to place it).

@skoren skoren added the enhancement New feature or request label May 3, 2022
@skoren skoren added this to the Version v1.1 milestone May 3, 2022
@brianwalenz
Copy link
Member

Consensus and layout should be happy using a subsequence now, but communicating which subsequence to use from verkko to layoutToPackage isn't implemented. Line 474 in get_layout_from_mbg.py needs to add (optional) trim amounts for the read.

From layoutToPackage.C:

  //  We're expecting a layout with format:
  //    tig  piece000001
  //    len  3434115
  //    rds  8738
  //    m54316_180808_005743/7668064/ccs  10831  0     200  900
  //    m54316_180808_005743/12583071/ccs  1510  11740   0  2000
  //    m54316_180808_005743/9240893/ccs   2002  12086
  //
  //  The whitespace is (probably) tabs, but we don't care.
  //
  //  The first pair of numbers is the position the trimmed read is expected
  //  to go.  The second pair is the amount to trim from the read in the
  //  orientation the read is placed in the tig (unitigConsensus.C:146).  So,
  //  the first read will be placed reversed, with 200 bp trimmed from the
  //  start (the original end) and 900 bp from the end (the original start):
  //
  //               0             10831
  //        [200bp]<------------------[900bp]
  //                  [0bp]-------------->[2000bp]
  //                          ------------->
  //

@skoren skoren removed this from the Version v1.1 milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants