Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to record.py should be removed from INSTALL.md #47

Open
jose1711 opened this issue Oct 20, 2020 · 2 comments
Open

Reference to record.py should be removed from INSTALL.md #47

jose1711 opened this issue Oct 20, 2020 · 2 comments

Comments

@jose1711
Copy link
Contributor

This line in INSTALL.md should be updated as record.py is no more

ffms (optional, for record.py)
@marcan marcan closed this as completed in 26fa370 Oct 21, 2020
@jose1711
Copy link
Contributor Author

Thank you. ffmsvideo.py still contains reference to ffms (even though it does not seem to be imported):

$ grep -r ffms
blitzloop/ffmsvideo.py:import ffms
blitzloop/ffmsvideo.py:        self.vsource = ffms.VideoSource(song.videofile)
blitzloop/ffmsvideo.py:        self.vsource.set_output_format([ffms.get_pix_fmt("bgr32")])

Maybe this could get removed too to make it clean.

@marcan marcan reopened this Oct 24, 2020
@marcan
Copy link
Owner

marcan commented Oct 24, 2020

Yup, that file needs to go. Reopening so I remember to do it (I'm not home now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants