-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only force JACK output if user did not specify --no-audioengine #51
Comments
This is just an option to blitzloop, |
I understand the option, but I think the logic should be slightly changed:
To put in into simple words: I believe specifying |
Ok, so just a "dynamic default" if you will. AFAIK the sane way of doing that is just defaulting to None and replacing that with the appropriate default in the mpvplayer code. |
IIUC
blitzloop
uses Jack only for adding Karaoke effect. If such effect is not needed (e. g. b/c echo effect is integrated into an USB mixer/soundcard) - i. e. a user specifies--no-audioengine
as command-line switch then I believe it would be better not to force it (and letmpv
use the default driver).The text was updated successfully, but these errors were encountered: