Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change private properties to protected in ClientImpl #168

Closed
alexmnv opened this issue Jun 20, 2018 · 1 comment
Closed

Change private properties to protected in ClientImpl #168

alexmnv opened this issue Jun 20, 2018 · 1 comment

Comments

@alexmnv
Copy link

alexmnv commented Jun 20, 2018

Why make the properties of ClientImpl private? For example, I need to get an underlying socket to use it in reactphp's event-loop. Given that socket property is private and there's no getSocket function, I can't get it in any other way than modifying the source code of ClientImpl directly (which isn't good practice). If socket were protected, I could just extend the class to implement getSocket function.

@alexmnv
Copy link
Author

alexmnv commented Jun 21, 2018

Thought it would be better just to implement getSocket() method, so I created a pull request #169

@alexmnv alexmnv closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant