Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle breaking change for ha-icon #313

Closed
elupus opened this issue Feb 6, 2024 · 16 comments
Closed

Handle breaking change for ha-icon #313

elupus opened this issue Feb 6, 2024 · 16 comments
Labels
bug Something isn't working

Comments

@elupus
Copy link
Contributor

elupus commented Feb 6, 2024

Which version of Room Card?
1.08.02

Describe the bug
A clear and concise description of what the bug is.

Some state icon's are no longer displayed correct.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
Correct state icon

Screenshots
image

See bottom left, and bottom right. There should be a outlet icon on the right.

Desktop (please complete the following information):

  • OS: OSX
  • Browser Chrome
  • Version

Additional context

https://developers.home-assistant.io/blog/2024/01/30/ha-state-icon-properties-changes/

YAML

@elupus elupus added the bug Something isn't working label Feb 6, 2024
@jamesgid-gc
Copy link

I am seeing the same behaviour since updating HA to the latest version. Although the icons are only displaying incorrectly through my web-browser on my desktop computer. On my android phone (Google Pixel 7) the icons are still correct.

room-card version: v1.08.02

Desktop (please complete the following information):
OS: Windows 11
Browser Chrome
Version 121.0.6167.14

Desktop:
image
image

Android Phone (and what they looked liked before on the desktop):
image
image

@DeWaHa
Copy link

DeWaHa commented Feb 8, 2024

I have the same problemen on my Android Phone and tablet.
The mediaplayer, presence, motion, smoke, co and heat icons are missing.

@elupus
Copy link
Contributor Author

elupus commented Feb 8, 2024

Did an initial fix attempt here: #314 but tests needs to be fixed and the fix needs to be actually tested :)

@DeWaHa
Copy link

DeWaHa commented Feb 8, 2024 via email

@TTLucian
Copy link

TTLucian commented Feb 8, 2024

Same problem here. Icons are all messed up on browser and android app.

@Belrix
Copy link

Belrix commented Feb 8, 2024

Ditto.

@boredomwontgetus
Copy link

+1

@marcokreeft87
Copy link
Owner

Seems to be fixed by the change of @elupus Please download the latest version everyone!

@calielc
Copy link

calielc commented Feb 9, 2024

It is a beta version 1.08.03 (https://github.com/marcokreeft87/room-card/releases/tag/1.08.03)

@DeWaHa
Copy link

DeWaHa commented Feb 9, 2024

How do we install this bèta not using Hacs?
Can someone explain please?

@TTLucian
Copy link

TTLucian commented Feb 9, 2024

Got it. For some reason HACS doesn't pick up the update. Go to room card in HACS, hit the 3 dots upper right, click update information then click redownload.

@marcokreeft87
Copy link
Owner

It is a beta version 1.08.03 (https://github.com/marcokreeft87/room-card/releases/tag/1.08.03)

No its not?

image

@marcokreeft87
Copy link
Owner

HACS is just bugging again as always

@DeWaHa
Copy link

DeWaHa commented Feb 9, 2024

Thanks TTLucian and macrokreeft87. Problem solved.

@marcokreeft87
Copy link
Owner

Did an initial fix attempt here: #314 but tests needs to be fixed and the fix needs to be actually tested :)

Can you confirm it's fixed with the new version?

@elupus
Copy link
Contributor Author

elupus commented Feb 10, 2024

Did an initial fix attempt here: #314 but tests needs to be fixed and the fix needs to be actually tested :)

Can you confirm it's fixed with the new version?

Yup! Works now. Thanx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants