Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use keyLoc and valueLoc for value definition diagnostic #248

Open
marcoroth opened this issue Apr 11, 2024 · 1 comment
Open

Use keyLoc and valueLoc for value definition diagnostic #248

marcoroth opened this issue Apr 11, 2024 · 1 comment
Labels
enhancement New feature or request feature Issue that implements a new feature. refactor Issue that refactors part of the existing code.

Comments

@marcoroth
Copy link
Owner

marcoroth commented Apr 11, 2024 •
edited
Loading

The pull request #212 implemented a new stimulus.controller.value_definition.unknown_type diagnostic. Though, all diagnostics related to value definitions were targeting the whole static values values section for the diagnostic range.

Thanks to @nachiket87 we were able to add keyLoc and valueLoc to ValueDefintion in marcoroth/stimulus-parser#102 which was released in [email protected].

We should now update the all the value definition diagnostics the Stimulus LSP has to use the newly added keyLoc and valueLoc properties to make the diagnostic ranges more accurate.
@marcoroth marcoroth added enhancement New feature or request feature Issue that implements a new feature. refactor Issue that refactors part of the existing code. labels Apr 11, 2024
@nachiket87 nachiket87 mentioned this issue Apr 11, 2024
Merged
@nachiket87
Copy link
Contributor

added the diagnostic range for the value only in this PR: #249 @marcoroth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature Issue that implements a new feature. refactor Issue that refactors part of the existing code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcoroth @nachiket87