Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search page #3

Open
marcovo opened this issue Jul 8, 2015 · 2 comments
Open

Search page #3

marcovo opened this issue Jul 8, 2015 · 2 comments

Comments

@marcovo
Copy link
Owner

marcovo commented Jul 8, 2015

https://www.phpbb.com/community/viewtopic.php?p=13958441#p13958441

on the search page all posts in the tag HIDE always hidden, even if a user posted in the subject in which they are located.
@marcovo
Copy link
Owner Author

marcovo commented Aug 31, 2015

generate_text_for_display() is called in line 1008 in search.php ( https://github.com/phpbb/phpbb/blob/3.1.x/phpBB/search.php#L1008 ), but isn't preceded by an event within the foreach() loop. Providing compatibility with this is possible, but can break very easily because in one loop you'll have to provide info (the topic-id) for the next loop already. Hence I will not implement this, or said event should be implemented...

@marcovo marcovo closed this as completed Aug 31, 2015
@marcovo
Copy link
Owner Author

marcovo commented Sep 2, 2015

With the new structure of the event-listener, this now is possible. See commit ae83f58 .

@marcovo marcovo reopened this Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcovo