Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks for posts #7

Open
marcovo opened this issue Aug 30, 2015 · 5 comments
Open

Thanks for posts #7

marcovo opened this issue Aug 30, 2015 · 5 comments

Comments

@marcovo
Copy link
Owner

marcovo commented Aug 30, 2015

https://www.phpbb.com/community/viewtopic.php?p=13917886#p13917886

Add an optional link with the Thanks for Posts extension, also see https://www.phpbb.com/community/viewtopic.php?f=456&t=2259046&hilit=thank+for+post .

@marcovo
Copy link
Owner Author

marcovo commented Sep 1, 2015

Compatibility implemented in this commit: 52ed482

Still needs elaborate testing.

@marcovo
Copy link
Owner Author

marcovo commented Sep 2, 2015

Since commit 101bf13 the texts have been edited, to correctly display why messages have been hidden, and how you can reveal them (by replying, by thanking, or both).

@Galixte
Copy link

Galixte commented Sep 3, 2015

Hi @marcovo,

we have to apply those edits in this PR: rxu/thanks_for_posts#45 to obtain the “Both” choice ?

@marcovo
Copy link
Owner Author

marcovo commented Sep 3, 2015

That's correct. For testing purposes, you can use the more compact edits in the first commit marcovo/thanks_for_posts@898e5b5 . The more comprehensive second commit was made to comply to the coding guidelines. So both commits serve the same functionality, but in different forms.

@Galixte
Copy link

Galixte commented Sep 3, 2015

thnaks ;=)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants